StakingEscrow: function to wrap and topUp stake in threshold staking … #122
+277
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzotova
requested review from
KPrasch,
arjunhassard,
cygnusv,
theref,
derekpierre and
manumonti
vzotova
force-pushed
the
wrap-top-up
branch
from
55d2ecb
to
5034202
Compare
derekpierre
approved these changes
Oct 10, 2023
Comment on lines
+343
to
+345
| vendingMachine.wrap(wrappedTokenAmount); | ||
| tToken.approve(address(tStaking), tTokenAmount); | ||
| tStaking.topUp(info.stakingProvider, uint96(tTokenAmount)); |
cygnusv
approved these changes
Oct 17, 2023
| StakerInfo storage info = stakerInfo[msg.sender]; | ||
| require(info.stakingProvider != address(0), "There is no stake in T staking contract"); | ||
| require( | ||
| tStaking.stakedNu(info.stakingProvider) == 0, |
There was a problem hiding this comment.
Is it possible that stakedNu() will be removed at some point?
There was a problem hiding this comment.
yep, it will be in second upgrade for threshold staking contract for removing legacy
vzotova
force-pushed
the
wrap-top-up
branch
2 times, most recently
from
87ad4b8
to
29b227c
Compare
…contract without withdrawing to staker's account
Co-authored-by: Derek Pierre <derek.pierre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…contract without withdrawing to staker's account